graspologic icon indicating copy to clipboard operation
graspologic copied to clipboard
verified publisher icon graspologic-org

Created seeded procrustes

Open aj-hersko opened this issue 3 years ago • 4 comments

  • [x] Does this PR have a descriptive title that could go in our release notes?
  • [ ] Does this PR add any new dependencies?
  • [ ] Does this PR modify any existing APIs?
    • [ ] Is the change to the API backwards compatible?
  • [ ] Have you built the documentation (reference and/or tutorial) and verified the generated documentation is appropriate?

Addresses the case of procrustes where seeds are used to find a more accurate Q and P.

Still working on issues with the testing, creating fit_transform, and importing BaseAlign

aj-hersko avatar Aug 05 '22 19:08 aj-hersko

having some issues making docs for the most recent commit

aj-hersko avatar Aug 05 '22 20:08 aj-hersko

im happy to review this as well if this ever happens

alyakin314 avatar Jan 12 '23 17:01 alyakin314

@aj-hersko if you still have any interest, do you mind resolving any of the conversations above which you already took care of?

bdpedigo avatar Jan 12 '23 18:01 bdpedigo

Sure. I resolved the ones I am sure I fixed but at this point there is an issue that is above my understanding of the code so I’d need to talk with someone about resolving my error before I try to commit again for others to comment on.

aj-hersko avatar Jan 15 '23 03:01 aj-hersko