graspologic icon indicating copy to clipboard operation
graspologic copied to clipboard

Propose removing I-DAD as a laplacian

Open bdpedigo opened this issue 3 years ago • 1 comments

related to #938

I propose that we don't need the I - DAD as an accepted laplacian, because:

pros:

  • our library always does SVD using top singular values, when using I - DAD one should be looking at the smallest in magnitude eigenvalues instead
  • we dont know of a paper that has a good definition of laplacian in the directed case for the I - version, though I'm guessing it'd be the same
  • reduce code footprint!

cons:

  • have to deprecate something

cc: @ebridge2

bdpedigo avatar Jul 06 '22 20:07 bdpedigo

remove all functionality related to I-DAD https://github.com/microsoft/graspologic/blob/dev/graspologic/utils/utils.py#L373

bdpedigo avatar Nov 29 '22 20:11 bdpedigo