graphql.github.io icon indicating copy to clipboard operation
graphql.github.io copied to clipboard

make sticky side menu items

Open igbominadeveloper opened this issue 5 years ago • 2 comments

What does this PR do?

This PR adds styles to make the sidebar menu sticky on desktop screens

Background context

The sidenav keeps scrolling with the page and makes it difficult when users need to navigate forcing them to scroll back up before they can navigate

What are relevant issue(s)?

#558

Screenshots

Annotation 2020-005-09 215804

Annotation 2020-05-09 215804

igbominadeveloper avatar Nov 04 '20 23:11 igbominadeveloper

Continuing the feedback in #558 - I'm not sure we should do this either, but this can't go in as it is because it means you have to scroll to the bottom in order to hit some of the links in the sidebar.

Adding a scrollview for the sidebar is an answer if it vertically overflows and allows scrolling inside the sidebar, but the permanent scrollbars feels bad on windows/linux too. So I'm leaning towards no.

orta avatar Nov 08 '20 15:11 orta

Continuing the feedback in #558 - I'm not sure we should do this either, but this can't go in as it is because it means you have to scroll to the bottom in order to hit some of the links in the sidebar.

Adding a scrollview for the sidebar is an answer if it vertically overflows and allows scrolling inside the sidebar, but the permanent scrollbars feels bad on windows/linux too. So I'm leaning towards no.

I understand this now and agree it is a bad UX to have to scroll to the bottom before you access some links. Although, I like the idea of adding overflow to the sidebar, I am not certain it would look great. Nevertheless, I shall give it a try

igbominadeveloper avatar Nov 12 '20 04:11 igbominadeveloper

please open a new PR when you have the right UI improvement in mind Thank you!

Urigo avatar Apr 09 '23 17:04 Urigo