graphql
Fix crash in node when mixing sync/async resolvers (backport of #3529)
This is a backport of ~#3529~ #3651 to the 16.x branch that fixes #3528.
Full credit to @asztal for identifying the fix and submitting the original PR.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: chrskrchr / name: Chris Karcher (e835b95783a8385e914a4c83ab82b5fe1ed1d179)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@IvanGoncharov - I finally worked through the EasyCLA issues, would you mind taking a look at this PR?
Hi @chrskrchr, I'm @github-actions bot happy to help you with this PR 👋
Supported commands
Please post this commands in separate comments and only one per comment:
-
@github-actions run-benchmark- Run benchmark comparing base and merge commits for this PR -
@github-actions publish-pr-on-npm- Build package from this PR and publish it on NPM
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@chrskrchr We are still blocked by missing CLA on #3529 and it should be signed first especially since all the code were copied from there.
We are still blocked by missing CLA on #3529 and it should be signed first especially since all the code were copied from there.
@IvanGoncharov - at what point would we consider #3529 abandoned? I don't want to prevent @asztal from getting credit for their great fix, but that PR was opened nearly 2 months ago and we'd like to get this fix rolled out to our production service as quickly as possible. (and remove some bandaids we wrapped around the issue to prevent it from causing a process exit)