graphene icon indicating copy to clipboard operation
graphene copied to clipboard

Simplify props.py

Open RJPercival opened this issue 2 years ago β€’ 2 comments

It had code for handling the differences between old-style and new-style classes in Python 2, but support for Python 2 was dropped long ago.

This could be simplified further, e.g. by skipping any attributes that start with an underscore, but that would be a behavioural change, whereas this PR is a pure refactoring.

RJPercival avatar Jul 04 '23 15:07 RJPercival

Thanks for the PR @RJPercival πŸ™‚ Could you please run the pre-commit hooks before commiting, so that the linter runs? Feel free to tag me after the PR is updated, will merge then. 😊

erikwrede avatar Jul 19 '23 07:07 erikwrede

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (d77d0b0) 96.01% compared to head (6d609db) 96.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   96.01%   96.00%   -0.01%     
==========================================
  Files          51       51              
  Lines        1755     1753       -2     
==========================================
- Hits         1685     1683       -2     
  Misses         70       70              
Impacted Files Coverage Ξ”
graphene/utils/props.py 100.00% <100.00%> (ΓΈ)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 19 '23 07:07 codecov[bot]