graphene icon indicating copy to clipboard operation
graphene copied to clipboard

Is graphql-relay actually a requirement if relay is not going to be used?

Open skewty opened this issue 5 years ago • 1 comments

I was hoping that graphql-relay could be removed as a base requirement in setup.py if it isn't actually required for people who have no need for relay.

Perhaps a specific install option like pip install graphene[relay] could be added for those that actually require it.

Obviously this would be a breaking change so it makes sense to do it before 3.0 is released if it will be done.

skewty avatar Nov 27 '20 02:11 skewty

+1

The graphql-relay dependency is preventing me from installing schemathesis in my project.

When running

python3 -m venv venv
source venv/bin/activate  
pip install graphene 
pip install schemathesis

I get

ERROR: graphql-relay 2.0.1 has requirement graphql-core<3,>=2.2, but you'll have graphql-core 3.1.2 which is incompatible.
ERROR: graphene 2.1.8 has requirement graphql-core<3,>=2.1, but you'll have graphql-core 3.1.2 which is incompatible.

If there isn't a very good reason to keep it as a core dependency, please move it to extras.

If there is a good reason to keep it, this conflict does not happen for graphql-relay v3, so alternatively you might consider changing the required versions in the setup.py.

sondrelg avatar Dec 21 '20 23:12 sondrelg