java-dataloader icon indicating copy to clipboard operation
java-dataloader copied to clipboard

fix: Dataloader helper Try classcast exception

Open ameerabdul opened this issue 10 months ago • 4 comments

Summary

  • Creating a new DataLoader with newMappedDataLoaderWithTry and batchingEnabled as false and cachingEnabled as true.
  • This will cause the value to which is already a Try instance to be wrapped again in another Try.succeed causing class cast exception

ameerabdul avatar Mar 10 '25 17:03 ameerabdul

Can we please have a unit test showing this working.

Its not enough to fix the code, we need to lock in that behavior

bbakerman avatar Mar 11 '25 03:03 bbakerman

I managed to do a reproducton of this. I can confirm its a genuine problem but this is not the fix for it

bbakerman avatar Apr 02 '25 02:04 bbakerman

Hello, this pull request has been inactive for 60 days, so we're marking it as stale. If you would like to continue working on this pull request, please make an update within the next 30 days, or we'll close the pull request.

github-actions[bot] avatar Jun 02 '25 01:06 github-actions[bot]

Hello, as this pull request has been inactive for 90 days, we're closing this pull request. We always welcome contributions, and if you would like to continue, please open a new pull request.

github-actions[bot] avatar Jul 03 '25 01:07 github-actions[bot]