graphql icon indicating copy to clipboard operation
graphql copied to clipboard

Adds support for custom marshalers through the encoding.TextMarshaler interface

Open Fontinalis opened this issue 6 years ago • 4 comments

This PR adds a check to each built-in coerce function, so if the value implements the encoding.TextMarshaler interface, it'll be marshaled and converted from that, so custom types, like some nullable type from github.com/guregu/null would work correctly.

Closes #471

Fontinalis avatar Apr 10 '19 15:04 Fontinalis

Waiting for at least one review.. I could merge it if it would be someone else’s PR, but cannot do it without a review since it’s mine..

On 2019. Apr 15., at 15:23, billkillapp [email protected] wrote:

Could we merge this feature ASAP?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Fontinalis avatar Apr 15 '19 13:04 Fontinalis

When are you going to merge this important feature into master?

limoli avatar Oct 11 '19 10:10 limoli

Coverage Status

Coverage decreased (-0.09%) to 92.288% when pulling b7c3a1a0edb90ee307e98123b35435323c03f578 on custom-marshaler into 02caa8943d64d9cd60bd67f2bc163676716bb963 on master.

coveralls avatar Mar 18 '20 09:03 coveralls

@chris-ramon Can you review this?

Fontinalis avatar Mar 18 '20 09:03 Fontinalis