graph-ts icon indicating copy to clipboard operation
graph-ts copied to clipboard

Added some docs comments to better identify fields that are just named `id`

Open maoueh opened this issue 3 years ago • 3 comments

And to better spot where transaction hash can be found.

maoueh avatar May 13 '22 14:05 maoueh

I need to re-write the comment removing mention of transactionHash as I mixed up Protobuf fields when I checked, so it's totally false, id are all receiptId.

maoueh avatar May 13 '22 18:05 maoueh

@maoueh checking the status of this, my understanding was that it's not possible to get the tx hash for the receipt at this time, but your original comment suggested it was?

azf20 avatar May 15 '22 21:05 azf20

@azf20 That’s correct, I thought one of the id was the transaction hash/id, but I was wrong and all id fields are actually referring to the receipt id.

So, there is no way to obtain today the transaction hash (some changes in graph-node is required to support that, probably passing more context to the receipt handler).

maoueh avatar Jul 20 '22 18:07 maoueh