graph-tooling icon indicating copy to clipboard operation
graph-tooling copied to clipboard

`graph protogen` command

Open saihaj opened this issue 1 year ago • 5 comments

We also want to add a feature that will generate the protobuf-as types... currently this is either done with https://github.com/gravitational/protobuf-as but its broken atm -- @mangas created a branch that works https://github.com/mangas/protobuf-as Ideally we would have a command in the CLI that was written like this... graph protogen --out=src/pb/ ./proto/*.proto From @kmjones1979 on Slack

saihaj avatar Mar 25 '24 18:03 saihaj

Hi @saihaj, with your approval will pick this up next. Can we discuss any potential reasons for choosing protobuf-as vs ts-proto with protoc?

joshuanazareth97 avatar Apr 27 '24 11:04 joshuanazareth97

Hey @saihaj, if you have a moment can we discuss me picking this task? Will work on it today / over the weekend and close by Monday if possible. Just wanted to know about protobuf-ts vs ts-proto for the solution.

joshuanazareth97 avatar May 03 '24 14:05 joshuanazareth97

thanks so much @joshuanazareth97! @mangas maybe has some context on that?

azf20 avatar May 03 '24 18:05 azf20

@mangas any input on using one vs the other?

joshuanazareth97 avatar May 06 '24 05:05 joshuanazareth97

We explored this a bit recently, see https://github.com/streamingfast/substreams-sink-examples/pull/4.

The substreams protogen command uses buf to facilitate generation. We also used a different code generator than what was used before.

maoueh avatar May 06 '24 14:05 maoueh