graph-tooling icon indicating copy to clipboard operation
graph-tooling copied to clipboard

Tests failing silently

Open 0xJem opened this issue 1 year ago • 3 comments

Which packages are impacted by your issue?

@graphprotocol/graph-cli

Describe the issue

Under macOS Sonoma, tests can fail silently (no error is printed). This seems to be an issue with matchstick. See:

  • https://github.com/LimeChain/matchstick-as/issues/66
  • https://github.com/LimeChain/matchstick/issues/421

Reproduction

https://github.com/OlympusDAO/olympus-protocol-metrics-subgraph/blob/bea228c830478218ca0c291ca941fb5a9d250111/subgraphs/ethereum/tests/OhmCalculations.test.ts#L250-L266

Steps to Reproduce the Bug or Issue

  1. Run yarn subgraph test ethereum
  2. The "closed auction/after bond expiry/all burned" test case in OhmCalculations should fail. No error is printed, even the name of the test case doesn't show up. (Search for the previous test case, "closed auction/after bond expiry", and it will show up.)

Expected behavior

The "closed auction/after bond expiry/all burned" test case should have failed and thrown an error.

Screenshots or Videos

No response

Platform

Subgraph Manifest

No response

Subgraph GraphQL Schema

No response

Additional context

No response

0xJem avatar Jan 25 '24 06:01 0xJem

Is it really not a priority to fix this??

0xJem avatar Aug 19 '24 18:08 0xJem

Is it really not a priority to fix this??

Not at the moment. However, if you'd like to contribute a patch, we'd be more than happy to accept it!

saihaj avatar Aug 20 '24 12:08 saihaj