graph-network-subgraph icon indicating copy to clipboard operation
graph-network-subgraph copied to clipboard

Integrate parsing and entity logic for contracts and events

Open mnlesane opened this issue 3 years ago • 4 comments

https://forum.thegraph.com/t/subgraph-contract-lookup/3274/

mnlesane avatar Apr 20 '22 15:04 mnlesane

Another thing I forgot to mention (and this one is on me) is that in our workflow we first merge to the branch mainnet-staging and then move it to master once it's synced and tested in staging environments.

I should probably update the README.md as well as CONTRIBUTING.md files, since there's probably no mention of this anywhere

juanmardefago avatar Apr 25 '22 14:04 juanmardefago

@mnlesane sorry for the long delay, I've been caught in a ton of stuff and missed these updates.

Overall it looks a lot cleaner now and I really like the approach!

Only thing missing is to double check that it's working as expected (I'd love to have tests in the subgraph soon, but for now at least double checking it on a synced version would be just fine)

juanmardefago avatar Jun 23 '22 19:06 juanmardefago

@juanmardefago All changes have been verified via a fork that was deployed to the hosted service. I wrote a simple test a while back for standardizeAddresses(), which I've added assertions to and checked into this branch. If unit tests should also be created for the parsing logic, please let me know.

mnlesane avatar Aug 06 '22 16:08 mnlesane

@mnlesane I mentioned I was going to merge this on #192, but it seems that the link you sent has a failed subgraph there. Just double checking, is the failed subgraph running the same code as this branch?

Happy to merge this if it's not, otherwise it'd be good to double check what happened before merging it, so we can fix it beforehand!

juanmardefago avatar Oct 24 '22 20:10 juanmardefago