graphnet icon indicating copy to clipboard operation
graphnet copied to clipboard

Addressing issue #753 by adding feature mapping for the Fourier Encoder

Open mobra7 opened this issue 1 year ago • 1 comments

Fix for issue #753 :

  • FourierEncoder (which is used in IceMix model) previously assumed a specific structure for the feature dimension, which caused issues with certain datasets (e.g. using standard FEATURES.ICECUBE86).
  • Now, FourierEncoder accepts a simple list of int or None to map the corresponding features of the data to the features used in FourierEncoder.
  • The Fourier mapping can be passed during the initialization of the DeepIce model. Specifying n_features is no longer required.

Minor Fixes:

  • Fixed small typos within IceMixNodes.

mobra7 avatar Oct 24 '24 13:10 mobra7

@mobra7 The problem with pre-commit is now fixed in main. If you update the branch, the failing checks in this PR is likely to pass (see #760).

RasmusOrsoe avatar Nov 05 '24 10:11 RasmusOrsoe

Due to inactivity this PR will be closed, #753 will remain open for a future PR

Aske-Rosted avatar Sep 02 '25 07:09 Aske-Rosted