postgraphile-lambda-example icon indicating copy to clipboard operation
postgraphile-lambda-example copied to clipboard

Fix postgraphile websocket/subscription omission path

Open jonathanpeterwu opened this issue 4 years ago • 4 comments

Description

On build for the lambda example webpack bundling fails on omission of subscriptions.js as the npm install path has changed

  • [x] My code matches the project's code style and yarn lint:fix passes.

jonathanpeterwu avatar Sep 18 '21 23:09 jonathanpeterwu

Please also update the yarn lock (assuming an upgrade is required to trigger the issue?)

benjie avatar Sep 19 '21 22:09 benjie

Updated with package upgrade

jonathanpeterwu avatar Sep 21 '21 20:09 jonathanpeterwu

@benjie is there a reason in particular we would not want to update to the most recent version of postgraphile?

SnowballAntrobus avatar Sep 23 '21 12:09 SnowballAntrobus

No; just that I've tested this on older versions and I don't fancy testing it again because working with Lambda is a PITA. I'd rather go with a "known good" version.

benjie avatar Sep 23 '21 12:09 benjie