graphhopper
How to test
How do we make this repository testable?
Before we would start a webserver and send requests and look at the responses. Should we use a similar approach here? If yes, we need to be able to start a server in this repo, otherwise we might only test the MapboxResponseConverter, but then we still need to start a GH instance.
If yes, we need to be able to start a server in this repo, otherwise we might only test the MapboxResponseConverter, but then we still need to start a GH instance
I see what you mean. It is probably not wrong to have it as a test dependency or with a separate maven module.
BTW: can we rename graphhopper-mapbox to graphhopper-navigation-mapbox? Although longer it better describes the package IMO.
BTW: can we rename graphhopper-mapbox to graphhopper-navigation-mapbox? Although longer it better describes the package IMO.
Ok sure, I can do that :). My idea was to call the overall package graphhopper-navigation and add different modules for specific conversions, so graphhopper-mapbox is a module of graphhopper-navigation, but I agree, it would make more sense to rename it as well :).
With #3 this should be mostly fixed. I still think we should somehow test the actual server execution to make sure that MapboxResource is tested as well, but at least we have an easy way to test the converter itself.