reco4php icon indicating copy to clipboard operation
reco4php copied to clipboard

Why is DatabaseService needed?

Open Nyholm opened this issue 9 years ago • 1 comments

Why is the GraphAware\Reco4PHP\Persistence\DatabaseService needed? (source)

It works as a wrapper for the ClientBuilder. Wouldn't it be simpler to typehint for a ClientInterace directly. That would remove an unneeded abstraction layer.

Nyholm avatar Oct 29 '16 15:10 Nyholm

The initial idea was to make it compatible with other graph dbs in the future, but I completely forgot this idea. So yes it makes sense to just have a typhint on ClientInterface

ikwattro avatar Feb 20 '17 20:02 ikwattro