grandnode
Reservation type product problems and enhancement
Hi guys, I have some question about the reservation system. I hope the result of this conversation will lead to the improvement of the reservation system. I have plans to improve the system and I solved some problems in my branch but I want to complete it with your help and finally can send related pull request to you. If any of the following is unclear, let me know and I'll try to explain more.
1- We have quantity in minute and hour intervals but don't have it in daily interval. Is there any reason? I know there is "Resource" field to add more than 1 record with same date. If we have resource field for minute and hour interval, it is wrong? Why we dont have quantity in daily interval?
2- Imagine we define daily interval from 25/8/2021 to 27/8/2021. Customer add 25/8/2021 to his/her cart. After that he/she want to add 25/8 to 27/8. System display a warning: "No free bookings in this period". Is it better to display "You added some of selected reservations before" instead of "No free bookings in this period"?
3- In \src\Web\Grand.Web.Admin\Controllers\ProductController.cs line 2675, Is "(IntervalUnit)model.Interval == IntervalUnit.Day)" correct? It should be change to "(IntervalUnit)model.IntervalUnit == IntervalUnit.Day)"?
4- Imagine "Include both dates" is inactive and admin define an only day interval. In this scenario, customer can see the reservation day but cannot reserve the day. It seems to be a bug.
5- Customer can reserve a reservation date or time more than the quantity that admin defined. It seems to be a bug.
6- I cannt understand the description of "Quantity" field: "Enter the amount of time. How many minutes or hours has one reservation". If anyone can, please explain to me, thanks.
7- In admin area, system display error If "Start date" and "End date" are not selected and press generate button. It's not big problem but it's better to correct it.
8- I think "Include both dates" dont have relation to generate calendar. It related to reservation setting and we can move it to top of the page and separate it with a line.
I leave this here for now but I have more idea. I hope we can upgrade the reservation system together. Thank u all
