grandnode2 icon indicating copy to clipboard operation
grandnode2 copied to clipboard

Delete vs Cancel order's item behaviour on partially shipped orders

Open TheFlo opened this issue 1 year ago • 1 comments

Hi GrandNode team,

Seems that cancelling or deleting an order's item don't have the same behaviour on the order's shipping status when the order is in "PartiallyShipped" status.

Looking at the code for the cancel order item we have : https://github.com/grandnode/grandnode2/blob/b7e201d02cc78d60a428d7f594f8d505f6f16fcb/src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/CancelOrderItemCommandHandler.cs#L66-L73 It handles both the "Shipped" and "Delivered" status.

Whereas for the delete order item, only the "Delivered" status is handled : https://github.com/grandnode/grandnode2/blob/b7e201d02cc78d60a428d7f594f8d505f6f16fcb/src/Business/Grand.Business.Checkout/Commands/Handlers/Orders/DeleteOrderItemCommandHandler.cs#L91-L93

Is this behaviour different by design or a well hidden bug ?

Kind regards,

TheFlo avatar Sep 11 '24 15:09 TheFlo

@TheFlo thanks, it's looks like a bug.

KrzysztofPajak avatar Sep 12 '24 19:09 KrzysztofPajak