grandnode2 icon indicating copy to clipboard operation
grandnode2 copied to clipboard

Issue-405 : Orders search with OrderNumber field

Open SunilParisi123 opened this issue 2 years ago • 6 comments

Issue-405 : Orders search with OrderNumber field

Resolves #issueNumber
Type: feature|bugfix|

Issue

Description of the issue this PR is solving, why it's happening, and how to reproduce it.

Solution

Summarize your solution to the problem. Please include short description.

Breaking changes

If you have a breaking changes, list them here, otherwise list none.

Testing

  1. List the steps needed for testing your PR.
  2. Assume that everyone already know how to run the GrandNode, and do the basic configuration.
  3. Be detailed enough that someone can work through it easily.

SunilParisi123 avatar May 20 '23 06:05 SunilParisi123

Issue: https://github.com/grandnode/grandnode2/issues/405

SunilParisi123 avatar May 20 '23 06:05 SunilParisi123

@KrzysztofPajak Can this be included?

Nikhil13x avatar May 24 '23 03:05 Nikhil13x

When we want to Filter the orders using OrderNumber (which customers will be aware of mainly) and this is not part of the search handler. When customer is having multiple orders and want to filter that using OrderNumber currently it's not supported in Order Service (GetOrderHandler). So this PR is for that to extend the search including OrderNumber too.

SunilParisi123 avatar May 24 '23 03:05 SunilParisi123

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

KrzysztofPajak avatar May 24 '23 14:05 KrzysztofPajak

@Nikhil13x, @SunilParisi123 Interface IOrderService has a method GetOrderByNumber why you don't want to use it ?

@KrzysztofPajak We wanted to show orders as Autocomplete list and wanted to show all the orders starting with the matching number.

SunilParisi123 avatar May 24 '23 15:05 SunilParisi123

@Nikhil13x when you limit to ordernumber you should get only one record. So I would like to recommend to use method GetOrderByNumber

KrzysztofPajak avatar May 25 '23 15:05 KrzysztofPajak