gector icon indicating copy to clipboard operation
gector copied to clipboard

Update GECToR to use latest AllenNLP (inference time only)

Open damien2012eng opened this issue 3 years ago • 5 comments

Hello. First of all, thanks for the wonderful work! Our team is deciding to update GECToR to use latest AllenNLP, so that it can be compatible to our existing system. We understand that it is not an easy job to do the updating for the whole codebase. Therefore, our team comes up a plan to only update the inference part and consumes the pre-trained models. Could you please take a look at and let us know if it makes sense to you? Here

Thanks so much!

damien2012eng avatar Sep 02 '22 15:09 damien2012eng

Hi @damien2012eng Great news! Thanks for sharing. In general, the plan looks good to me. I understand why you decided to work only with the inference part. When ready, we will be happy to add your fork/branch to the repository's README.

skurzhanskyi avatar Sep 07 '22 09:09 skurzhanskyi

Checkout gector-fast repository

skurzhanskyi avatar Oct 08 '22 09:10 skurzhanskyi

@skurzhanskyi I checked out the gector-fast repo. However, it still uses the old Python and legacy version of Pytorch. Besides, our PRs will be ready soon (currently in the internal review).

damien2012eng avatar Oct 08 '22 19:10 damien2012eng

@skurzhanskyi Please review the first PR. Two more PRs are coming!

damien2012eng avatar Oct 13 '22 19:10 damien2012eng

@skurzhanskyi Please review the first PR. Two more PRs are coming!

I've update the pytorch version and dependencies. You can try it now.

Jason3900 avatar Aug 02 '23 03:08 Jason3900