gramjs icon indicating copy to clipboard operation
gramjs copied to clipboard

bad_msg_notification are not handled correctly

Open Lonami opened this issue 6 years ago • 3 comments

I know there's a TODO already, but this is bad: https://github.com/gram-js/gramjs/blob/a5b9864c5d027a806ffa3af1c25bc45641ae4434/gramjs/network/MTProtoSender.js#L570-L577

This is prone to causing 4865 bad_msg_notification before Telegram errors with 429 Too Many Requests at the transport level.

Lonami avatar Apr 30 '20 19:04 Lonami

@Lonami I wanted to help with this would you mind sharing how do I setup a case to replicate this and handle this? Maybe point me to the telegram doc that talk about this would be very helpful.

mannguyen0107 avatar Jan 11 '22 07:01 mannguyen0107

I personally would try to inject some code to "skip" handling a message at a desired point (for example the 100th message or when a file exists), and then confirm it fails. Once that's in place a workaround can be developed. I do not know which part exactly talks about this, the best I remember is https://core.telegram.org/mtproto/service_messages_about_messages.

Lonami avatar Jan 11 '22 12:01 Lonami

Thank you I will put this on my todo list once I finish with adding convenience event handlers @painor can you assign this issue to me so I wont forget thank you!

mannguyen0107 avatar Jan 11 '22 14:01 mannguyen0107