pyroscope icon indicating copy to clipboard operation
pyroscope copied to clipboard

New version in the footer mismatch with actual latest version

Open eh-am opened this issue 4 years ago • 4 comments

Feature originally developed in https://github.com/pyroscope-io/pyroscope/pull/333

Here's an example posted in slack:

The user is running 0.2.4 but the message says 0.2.3 is the latest version! image (27)

eh-am avatar Nov 02 '21 12:11 eh-am

This might be because of the resent split of the docs repo. I'll investigate

petethepig avatar Nov 02 '21 16:11 petethepig

image

Still seeing this issue /cc @petethepig

Rperry2174 avatar Dec 16 '21 20:12 Rperry2174

I think it's a race condition where the demo gets deployed on the new version before we even update the latest-version.json on pyroscope.io

I'll figure something out..

petethepig avatar Dec 16 '21 21:12 petethepig

After talking with @petethepig It looks like we need to parse semVer and check if the current version is smaller than the "newer" version.

https://github.com/pyroscope-io/pyroscope/blob/main/webapp/javascript/components/Footer.tsx#L35

eh-am avatar Jul 06 '22 19:07 eh-am