plugin-tools icon indicating copy to clipboard operation
plugin-tools copied to clipboard

Create plugin: CI workflow improvements

Open sunker opened this issue 1 year ago • 1 comments

What this PR does / why we need it: This PR is making a few changes to the e2e related workflow bits:

  • Use the right snippet in the article that walks through how to run e2e tests in ci
  • Not doing a sparse checkout of the repo anymore in the e2e test job. Doing a sparse checkout have little benefits, and may cause confusion when contributors wants to go beyond the basic steps in the workflow. See this thread for example.
  • Adds step that uploads Playwright report to GCS in case org is Grafana. Please note that even though someone were to falsely specify grafana as the org, this step would still not work for them as it requires access to id-tokens that are only available for repos within the grafana org.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

sunker avatar Apr 24 '24 12:04 sunker

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new patch release. NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

github-actions[bot] avatar Apr 24 '24 12:04 github-actions[bot]

Thanks for the review folks. Have removed the grafana specific bits and commented out the report uploading step (see this commit). Let me know what you think.

sunker avatar May 22 '24 06:05 sunker

:rocket: PR was released in @grafana/[email protected] :rocket: