fpGUI icon indicating copy to clipboard operation
fpGUI copied to clipboard

FillChar called with incorrect parameters

Open deanm73 opened this issue 2 years ago • 1 comments

src/corelib/x11/fpg_x11.pas line 1261: FillChar(ErrText,0, SizeOf(ErrText)); src/corelib/fpg_widget.pas line 201: FillChar(p^.Params, 0, SizeOf(p^.Params)); line 235: FillChar(m.Params, 0, SizeOf(m.Params));

In all of the above cases 2nd and 3rd parameters have been swapped - size should be 2nd and value 3rd.

deanm73 avatar Jun 08 '23 07:06 deanm73

Thank you for reporting.

By the way, the file for cases 2 and 3 is fpg_msgqueue.inc.

I created a branch in my fork for that issue and made a PR.

As I am not sure to have done it correctly, here is what I did:

git checkout -b fillchar_param

and after doing the modifications:

git add .
git commit -m "FillChar parameters order"
git push --set-upstream origin fillchar_param

rchastain avatar Jun 24 '23 05:06 rchastain