gpodder
Feature/cap max downloaded
If you want this, it does the following:
- Doesn't affect existing operation
- If the config
limit.downloads.podcast_max_newis set to5(for example), then 5 episodes are downloaded in thedownloadcommand
Isn't this something the user decides by themselves, either you download or you don't I'm not aware of auto-downloading? (I'm pretty sure there would be pitchforks if we had auto-downloading considering the response to episode art)
Note that it does not change default operation, it simply allows you to change the default of 200 downloads to whatever number you want. On a system with constrained memory, 200 is a lot
On Sat, Oct 24, 2020, 5:54 PM Keeper-of-the-Keys [email protected] wrote:
Isn't this something the user decides by themselves, either you download or you don't I'm not aware of auto-downloading? (I'm pretty sure there would be pitchforks if we had auto-downloading considering the response to episode art)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gpodder/gpodder-core/pull/38#issuecomment-716060287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWBSADHBZPCKZIMNWJVDDSMNEKHANCNFSM4N5OEAXQ .
Sorry for the extremely delayed response life got a bit in the way.
I'm still not 100% clear on this, since the download command is something the user chooses to run by themselves why do we need to limit this if they download too many episodes they would be barred from downloading more before clearing space.
I'm guessing your use case is different thus necessitating this approach but still would like to understand it more.
(Also one long podcast can be equal in size to lots of other podcasts combined)
I put it on a Raspberry Pi. Stuff You Should Know has 1657 episodes. When I ran download, it almost filled up my SD card.
The download command in gpo downloads everything. No limitations
I see, this is indeed a different use case then what I usually focus on.
Wouldn't using fetch instead of download make more sense for you? Downloads stated purpose is to download all new episodes while you can list & chose using other commands as far as I can tell from the gpo documentation.
To be clear the main reason I'm worried about this change is that it changes the way user-facing a function behaved until now, personally I don't use gpo rather gpodder-core functions as the core lib for a SailfishOS application
Maybe we can change this into:
gpo download 200
Thus the default behavior of download remains unchanged while also allowing the end user to limit how many episodes are downloaded using the download command should they so desire.
So a user with space concerns:
- Limit their downloads every time they use the
downloadcommand by adding an optional parameter or - Set an optional parameter once
It's a don't-care to me, as I'm using my fork. But the need is real, hence my PR. Helms discretion