Gregory Anders

The strings should match the (entire) directory name that you want to ignore, i.e. there is an implicit `^` and `$` at the beginning and end of each string. We...

Supporting only function arguments certainly does make the implementation more straight forward at the cost of making the *interface* harder to use for simple cases. Being able to use a...

You can start by resolving the merge conflicts on this branch (i.e. rebase onto latest master). Once that's done we can do a code review.

>Are we sure that there are real performance concerns if we do this unconditionally? I would imagine a simple gsub that fails would have a negligible cost. I agree. @smjonas...

> > Does this include the separate pattern_env table that is expanded unconditionally? (Hard to tell from the table.) > > Using that, there is no noticeable slowdown. A disadvantage...

> > In vim.filetype.add you could just add it to the pattern_env table if the pattern contains a ${SOME_VAR}. > > Done. Btw, how can priorities be handled with that...

lint job failure is unrelated to this PR: ``` /home/runner/work/_temp/f769ee7a-1ecd-44eb-8efc-7404d00dbed4/stylua: 1: ELF

�
��@@�@8: not found /home/runner/work/_temp/f769ee7a-1ecd-44eb-8efc-7404d00dbed4/stylua: 2: Syntax error: ")" unexpected ``` lintlua passes when I run it locally.

I would not remove lsp.buf_get_clients yet. We can vim.deprecate() it in 0.8 and remove it in 0.9. But it should be deprecated in a release before being removed so that...

Related https://github.com/neovim/neovim/issues/18290 This is probably up to @justinmk whether this is the approach we want to take (among the alternatives listed in #7270). Seems reasonable to me though.

[dmesg.log](https://paste.sr.ht/~gpanders/734e3a49be311384541efc4ff7b06debe0494c1f)