diffdf icon indicating copy to clipboard operation
diffdf copied to clipboard

lintrs on test files

Open kieranjmartin opened this issue 1 year ago • 2 comments

Test files fail lintr currently, but not being picked up by cicd. Should be fixed in seperate PR

kieranjmartin avatar Apr 09 '24 15:04 kieranjmartin

Is this being addressed by #93 ?

gowerc avatar Apr 09 '24 16:04 gowerc

No I just fixed the tests which were noticed by cicd; the remaining tests remain unlinted. I could have fixed it there but thought it was cleaner in a seperate PR. Won't action this until both the current PRs are complete as otherwise I will get git conflicts.

If you decide to do this styler seems to work very well btw; in the cases where I used it it seemed to just fix all the issues (you need to specify the correct indent) without breaking anything

kieranjmartin avatar Apr 10 '24 08:04 kieranjmartin