Gauthier

Results 813 comments of Gauthier

I think the logic should be enhance to retrieve various entities. The way the `schema` parameter work in most of the DB Metadata function is as follows: > schemaPattern -...

> @gotson, Hi, again, can we discuss acceptance criteria regarding this pr? Currently, it needs to add some unit tests, and we can probably discuss if anything else is required....

> @gotson Well, there are some. Most importantly, if the value of the schema pattern is null, it will show all DBs instead of only 'main', that may look like...

> @gotson Sorry, could you look at the current state of pr and see if anything else is required? The PR has conflict, you would need to fix those before...

> @gotson I resolved the conflict with the recent two commits Thank you. I don't have much time these days, but I will look at this when I have time.

I still see conflicts though. Are you sure you pushed your latest changes?

Weird indeed ![SmartSelect_20230419_220608_Chrome](https://user-images.githubusercontent.com/2139133/233100617-c8927086-902d-44c0-a14e-4372d860f769.jpg)

My bad, it's only the rebase (which was selected by default) that can't be done. Squash and merge is ok (and it's what we want). ![SmartSelect_20230419_220755_Chrome](https://user-images.githubusercontent.com/2139133/233101197-aee774b2-cf59-4377-8fbd-45bed2e0e87c.jpg)

code formatting is failing, can you fix it with `mvn spotless:apply` ?

> @gotson Hi there! I hope you're doing well. I wanted to reach out and kindly ask if you had a chance to review the pull request. It's on my...