react-native-bottom-sheet icon indicating copy to clipboard operation
react-native-bottom-sheet copied to clipboard

feat: add onDragStart onDragEnd gesture callbacks

Open arekkubaczkowski opened this issue 2 years ago • 10 comments

Given the significant interest and numerous requests from the community for this feature, I'm excited to introduce it with this pull request.

resolves #998, #1147

arekkubaczkowski avatar Apr 10 '24 20:04 arekkubaczkowski

@gorhom I think it's also worth to add a callbacks that run on UI thread to react on the changes without unnecessary rerenders. However I need to think a bit about some intuitive API for that

arekkubaczkowski avatar Apr 11 '24 06:04 arekkubaczkowski

Additionally I would also consider adding them to some hook so user can interact with it from any place.

arekkubaczkowski avatar Apr 11 '24 06:04 arekkubaczkowski

@gorhom I would be really grateful for review

arekkubaczkowski avatar Apr 16 '24 05:04 arekkubaczkowski

Awesome! Can't wait to see it merged. We've been patching this manually for quite some time. Would be nice to see it in the library.

jakubdrozdek avatar Apr 19 '24 07:04 jakubdrozdek

Hi @arekkubaczkowski. Do you know when this awesome feature will be merged & released ?

AndreiTimofte96 avatar Apr 25 '24 16:04 AndreiTimofte96

Hi @arekkubaczkowski. Do you know when this awesome feature will be merged & released ?

I have no idea, it seems like @gorhom is very busy.

arekkubaczkowski avatar Apr 25 '24 16:04 arekkubaczkowski

@arekkubaczkowski - I am currently trying to tap into some functionality like this and I believe @gorhom's intent is to use gestureEventsHandlersHook to provide callbacks for handleOnStart, handleOnEnd, handleOnActive.

Am I missing the intent of this PR?

phillipkey avatar Apr 26 '24 21:04 phillipkey

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar May 27 '24 09:05 github-actions[bot]

@phillipkey could you provide some example on how to properly use gestureEventsHandlersHook without defining redundant boilerplate? I am not sure if I am missing something but based on official example it require to provide the entire logic from scratch instead of adding custom logic on the top of existing one.

arekkubaczkowski avatar May 27 '24 11:05 arekkubaczkowski

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 27 '24 09:06 github-actions[bot]

that's a shame it's been closed. Hopefully someone will reopen it. cc @gorhom

arekkubaczkowski avatar Jul 08 '24 07:07 arekkubaczkowski

@arekkubaczkowski any idea when this feature will be availabe to use?

arbaaz-suggaa avatar Jul 11 '24 12:07 arbaaz-suggaa