uBlock icon indicating copy to clipboard operation
uBlock copied to clipboard

"create" filter button disabled

Open mapx- opened this issue 8 years ago • 2 comments

  • windows 10

  • FF 58.0b11 (64-bit) uBo 1.14.21rc4 or

  • chrome Version 64.0.3282.24 (Official Build) beta (64-bit) uBo dev build 1.14.21.104

  • go to google.com

  • open dashboard, logger

  • refresh page

  • choose some element to block for example: notifications.google.com

  • Click on the 4th cell of a log entry => to create a static filter

  • create the filter => ||notifications.google.com

Now refresh the page, go into "my filters" tab, delete the filter. Repeat exactly the same steps above. When the filter was created exactly as in the first step => the "Create" button is disabled.

It does not matter which is the test page.

mapx- avatar Dec 16 '17 09:12 mapx-

probably same root origin:

  • disable "my filters" list
  • use element picker to create a cosmetic filter
  • the filter is written in "my filters" section but should not apply (on refreshing page)

mapx- avatar Dec 17 '17 08:12 mapx-

Without looking into it, I think I remember keeping a list of the latest filters created through that UI, and disable the create button if there is an attempt to create the same filter again. I did not take into account that the user could delete the filter and re-create again. I need a better approach to prevent creating duplicate filters.

gorhill avatar Jan 01 '18 13:01 gorhill