framework icon indicating copy to clipboard operation
framework copied to clipboard

feat: optimize validator

Open devhaozi opened this issue 1 year ago • 2 comments

Closes #

📑 Description

此 PR 将之前位于各 HTTP 驱动中的 filter 调用挪至框架验证器部分,并优化了一个测试用例。

✅ Checks

  • [x] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [x] All the tests have passed

ℹ Additional Information

devhaozi avatar Mar 16 '24 17:03 devhaozi

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.59%. Comparing base (60102dd) to head (6a3a851).

Files Patch % Lines
validation/options.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
- Coverage   71.61%   71.59%   -0.02%     
==========================================
  Files         167      167              
  Lines       10134    10136       +2     
==========================================
  Hits         7257     7257              
- Misses       2317     2318       +1     
- Partials      560      561       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 16 '24 17:03 codecov[bot]

测试中发现一个上级 bug,已经提交 issue:https://github.com/gookit/validate/issues/262

这个 PR 可以先放着不合并

devhaozi avatar Mar 16 '24 18:03 devhaozi

太久了,暂时关了,后面有需要再说。

devhaozi avatar Jun 25 '24 18:06 devhaozi