framework icon indicating copy to clipboard operation
framework copied to clipboard

fix: copy nested directories when using app.Publishes

Open rohitkeshwani07 opened this issue 2 years ago • 2 comments

Closes # Issue 345

📑 Description

This will support copy of nested directories when needed with app.Publishes() as used by goravel/gateway here

✅ Checks

  • [x] My pull request adheres to the code style of this project
  • [ ] My code requires changes to the documentation
  • [ ] I have updated the documentation as required
  • [ ] All the tests have passed

rohitkeshwani07 avatar Jan 03 '24 12:01 rohitkeshwani07

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (aa22c1c) 69.26% compared to head (a396120) 69.21%. Report is 1 commits behind head on master.

Files Patch % Lines
foundation/console/vendor_publish_command.go 64.28% 11 Missing and 4 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
- Coverage   69.26%   69.21%   -0.06%     
==========================================
  Files         152      152              
  Lines       10922    10949      +27     
==========================================
+ Hits         7565     7578      +13     
- Misses       2849     2859      +10     
- Partials      508      512       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 05 '24 11:01 codecov[bot]

Could you please add unit tests for your new logic? And create your PR based on the v1.13.x branch, we can merge this PR to v1.13.x, and release v1.13.8. Thanks so much.

hwbrzzl avatar Jan 06 '24 01:01 hwbrzzl