framework icon indicating copy to clipboard operation
framework copied to clipboard

feat: add chunk by query methods (#714)

Open arashackdev opened this issue 2 months ago • 4 comments

📑 Description

Addresses https://github.com/goravel/goravel/issues/714 by adding chunk by methods.

This PR adds four new methods to the ORM:

  1. Chunk
  2. ChunkByID
  3. ChunkByIDDesc: Exists in Laravel and is a low-hanging fruit to add here.
  4. OrderedChunkByID: Exists in Laravel and is an enabler to the previous two methods.

arashackdev avatar Dec 01 '25 02:12 arashackdev

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.56%. Comparing base (d029a42) to head (9be5fb6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   68.56%   68.56%           
=======================================
  Files         264      264           
  Lines       15566    15566           
=======================================
  Hits        10673    10673           
  Misses       4430     4430           
  Partials      463      463           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 01 '25 02:12 codecov[bot]

~I'm getting this error in actions' mockery (not related to mocks):~

fatal: invalid reference: feature/chunk-by-queries
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v7/index.js:17:19)
    at ChildProcess.emit (node:events:508:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5) {
  code: 128
}
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v7/index.js:17:19)
    at ChildProcess.emit (node:events:508:28)
    at maybeClose (node:internal/child_process:1101:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

~Not sure how critical it is, would check and dive deeper if it becomes a blocker.~

Edit: Fixed by regenerating mock file.

arashackdev avatar Dec 01 '25 02:12 arashackdev

Review Ready.

arashackdev avatar Dec 01 '25 02:12 arashackdev

Thanks @arashackdev, I'll check it.

hwbrzzl avatar Dec 01 '25 02:12 hwbrzzl