gophercloud icon indicating copy to clipboard operation
gophercloud copied to clipboard
verified publisher icon gophercloud

octavia: add DomainName and HTTPVersion on monitors (added in 2.10) #2730

Open snigle opened this issue 2 years ago • 4 comments

Fixes #2730

Links to the line numbers/files in the OpenStack source code that support the code in this PR: https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=list-health-monitors-detail#list-health-monitors

snigle avatar Aug 25 '23 12:08 snigle

Coverage Status

coverage: 79.14%. remained the same when pulling 50bfb401684d2455671f4ed4c57a9c0d2f471035 on ovh:octaviaFeature into dd0d36f663b69361ed3b5db4bced9caad18c542c on gophercloud:master.

coveralls avatar Aug 25 '23 12:08 coveralls

CI seems unhappy now with

ERROR octavia.network.drivers.neutron.allowed_address_pairs [None req-e3045032-a87e-405a-9ebd-22444b123442 admin admin] Error creating neutron port on network fe1b4794-ce05-4b25-9fa9-7aa5f3ca23b7 due to ConflictException('ConflictException: 409').: openstack.exceptions.ConflictException: ConflictException: 409: Client Error for url: http://10.1.0.39:9696/networking/v2.0/ports, IP address 192.168.2.127 already allocated in subnet 80595bf8-fe08-485f-a1b3-1f03ea35e965

EmilienM avatar Aug 25 '23 14:08 EmilienM

Could you please rebase, so it'll trigger CI again and if green I'll merge it.

EmilienM avatar Oct 25 '23 14:10 EmilienM

looking forward to this PR being merged..

akamac avatar Apr 10 '24 17:04 akamac