android-maps-utils icon indicating copy to clipboard operation
android-maps-utils copied to clipboard

Unignore tests that should run on Robolectric

Open barbeau opened this issue 5 years ago • 10 comments

Is your feature request related to a problem? Please describe. In https://github.com/googlemaps/android-maps-utils/pull/649 we changed from using an emulator on Travis to using Robolectric CI, which means that all instrumented tests that were previously in the androidTest folder got moved to the test folder so they run on the JVM instead of an Android device or emulator.

In the first implementation of Robolectric in https://github.com/googlemaps/android-maps-utils/pull/649, we had to ignore some tests that failed on Robolectric - these are all currently annotated with @Ignore.

Describe the solution you'd like We should try and get the ignored tests running on Robolectric.

Here are tests that we should try to get running first, which previously ran on the emulator on Travis:

  • KmlContainerParserTest - entire class

These tests would be nice-to-have, although they were already skipped on the emulator on Travis because of existing issues:

  • GeoJsonPointStyleTest.testIcon()
  • KmlStyleTest.testMarkerColorLeadingSpace()
  • KmlStyleTest.testMarkerColorTrailingSpace()

Describe alternatives you've considered

  • Do nothing - continue to ignore the tests
  • Try out Firebase Test Lab - https://firebase.google.com/docs/test-lab

Additional context https://github.com/googlemaps/android-maps-utils/pull/649 contains some notes in the comments for issues I ran into when implementing Robolectric.

https://github.com/googlemaps/android-maps-utils/pull/573 contains some notes on why the nice-to-have tests were failing on the emulator on Travis.

barbeau avatar Mar 12 '20 19:03 barbeau

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

stale[bot] avatar Jul 10 '20 23:07 stale[bot]

Still an issue

barbeau avatar Jul 13 '20 22:07 barbeau

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

stale[bot] avatar Nov 11 '20 00:11 stale[bot]

Still valid

barbeau avatar Nov 12 '20 18:11 barbeau

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

stale[bot] avatar Mar 19 '21 23:03 stale[bot]

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.

stale[bot] avatar Sep 19 '21 19:09 stale[bot]

Closing this. Please reopen if you believe it should be addressed. Thank you for your contribution.

stale[bot] avatar Apr 16 '22 04:04 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

stale[bot] avatar Sep 21 '22 02:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. Please comment here if it is still valid so that we can reprioritize. Thank you!

stale[bot] avatar Jun 18 '23 08:06 stale[bot]

Not stale

barbeau avatar Jun 18 '23 13:06 barbeau