android-maps-compose icon indicating copy to clipboard operation
android-maps-compose copied to clipboard

feat: customize MarkerInfoWindow's Marker using Composable

Open mosmb opened this issue 2 years ago • 8 comments

Add Composable support for Marker inside MakerInfoWindow

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [X] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [X] Ensure the tests and linter pass
  • [X] Code coverage does not decrease (if any source code was changed)
  • [X] Appropriate docs were updated (if necessary)

Fixes #383 🦕

mosmb avatar Aug 21 '23 07:08 mosmb

hi @wangela any news for this one?

mosmb avatar Sep 26 '23 20:09 mosmb

Hi @mosmb ,

Could you add a small sample in the BasicMapActivity? Just a MarkerInfoWindow somewhere.

kikoso avatar Jan 09 '24 18:01 kikoso

Hi @mosmb . Did you have the chance to take a look at the comment above? With the sample we should be able to merge the PR.

kikoso avatar Oct 16 '24 09:10 kikoso

Ooops completely forgot about this, will do ! @kikoso

mosmb avatar Oct 16 '24 11:10 mosmb

Hi @mosmb. It seems that your commit went under an address that did not sign the CLA:

https://github.com/googlemaps/android-maps-compose/pull/384/checks?check_run_id=31618939418

kikoso avatar Oct 16 '24 13:10 kikoso

@kikoso Done, should be good now. Do not hesitate if you have any feedbacks. CLA check failed because I changed my GitHub name and forgot to submit a new one, it's done now.

mosmb avatar Oct 16 '24 13:10 mosmb

ping @kikoso

mosmb avatar Oct 22 '24 08:10 mosmb

Hi @mosmb ! We will take a look at this next week, thanks for putting it together.

kikoso avatar Oct 22 '24 08:10 kikoso

:tada: This PR is included in version 6.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

googlemaps-bot avatar Oct 29 '24 16:10 googlemaps-bot