open-match icon indicating copy to clipboard operation
open-match copied to clipboard

flaky test in testing/e2e/cluster_test.go

Open joeholley opened this issue 2 years ago • 0 comments

What happened: flaky test was removed from 1.7 -> 1.8 in testing/e2e/cluster_test.go. Diff them to see it: https://github.com/googleforgames/open-match/compare/release-1.7...release-1.8

This failure is caused by updating the open match config - this test just checks the config against another copy of the config... I'm not sure this actually has any value. If the intention is to make sure no unintentional changes get committed to the config file, that should be handled by source control approvals, not be a test inside the application code. Either way, the latest bitnami chart lets k8s generate the endpoint name, which then gets populated to the configmap (it's random). If we do want this as an application-level test, it needs to be reworked to ignore that param in the config (or some other solution). Open to discussion.

How to reproduce it (as minimally and precisely as possible): Run the e2e tests job in the cloudbuild config at commit af4d6ce

joeholley avatar Aug 31 '23 00:08 joeholley