agones icon indicating copy to clipboard operation
agones copied to clipboard

Dashboard for Agones GameServer State duration

Open vicentefb opened this issue 1 year ago • 29 comments

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking /kind bug /kind cleanup /kind documentation /kind feature /kind hotfix /kind release

What this PR does / Why we need it: There's no dashboard in Grafana for agones_gameserver_state_duration metric

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

vicentefb avatar Aug 13 '24 23:08 vicentefb

image

vicentefb avatar Aug 13 '24 23:08 vicentefb

Build Failed :sob:

Build Id: a200c7f4-cecc-468b-87e4-7d537bc449f8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Aug 13 '24 23:08 agones-bot

Build Succeeded :partying_face:

Build Id: 0e8c697c-de14-46e2-85d4-8c97469c470b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://3a0e864-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-3a0e864

agones-bot avatar Aug 14 '24 00:08 agones-bot

Build Failed :sob:

Build Id: 83cfc58c-f55d-4c91-b4ff-34feba5987b7

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Aug 15 '24 21:08 agones-bot

Build Succeeded :partying_face:

Build Id: 33716bfe-8b0f-4101-a648-9c49127bbc13

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://b0d475b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b0d475b

agones-bot avatar Aug 15 '24 23:08 agones-bot

Just tried installing this, and I no longer see the the dashboard for "Agones Gameservers", so there's something not quite right with the ConfigMap export.

image

Did you test reimporting the dashboard? 🤔

markmandel avatar Aug 16 '24 10:08 markmandel

Forgot to ask, which versions of prom and grafana are you running?

❯ helm ls -a -n metrics
NAME    NAMESPACE       REVISION        UPDATED                                 STATUS          CHART                   APP VERSION
grafana metrics         2               2024-08-16 10:52:53.523460868 +0000 UTC deployed        grafana-8.4.4           11.1.3
prom    metrics         3               2024-08-16 08:26:53.823474912 +0000 UTC deployed        prometheus-25.26.0      v2.54.0

That's what I have installed.

markmandel avatar Aug 16 '24 10:08 markmandel

Build Succeeded :partying_face:

Build Id: 42c93c05-1644-444f-bc8e-7b0759c5ff18

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://94b646f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-94b646f

agones-bot avatar Aug 16 '24 21:08 agones-bot

Build Succeeded :partying_face:

Build Id: 6cddafe5-5166-4050-9593-c44920d0a4ee

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://4eae250-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-4eae250

agones-bot avatar Aug 20 '24 19:08 agones-bot

Build Succeeded :partying_face:

Build Id: c3ba88cc-039d-45fd-86fe-f5c7dd462741

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://7164d3f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-7164d3f

agones-bot avatar Aug 21 '24 08:08 agones-bot

I can see the the dashboard for "Agones Gameservers" using the ConfigMaps in this PR. Looking at @markmandel 's screenshot, dashboard for "Agones Allocator Resource" is also missing. I'm gonna leave this to @vicentefb and @markmandel to figure out what's wrong.

image

gongmax avatar Aug 21 '24 22:08 gongmax

My versions of prom and grafana

> helm ls -a -n metrics 
NAME   	NAMESPACE	REVISION	UPDATED                                	STATUS  	CHART             	APP VERSION
grafana	metrics  	1       	2024-08-21 22:38:16.319785651 +0000 UTC	deployed	grafana-8.4.6     	11.1.4
prom   	metrics  	1       	2024-08-21 22:35:52.031204554 +0000 UTC	deployed	prometheus-25.26.0	v2.54.0

gongmax avatar Aug 21 '24 22:08 gongmax

Build Succeeded :partying_face:

Build Id: 81af7d9c-5556-47c8-a4b7-edf6e1707417

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://55eb971-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-55eb971

agones-bot avatar Aug 22 '24 00:08 agones-bot

Build Failed :sob:

Build Id: 18136030-c1aa-4d78-8dea-0b0ad23e1861

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Aug 22 '24 15:08 agones-bot

Build Succeeded :partying_face:

Build Id: 94a69712-c877-4940-b601-29bc14d5c431

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://b8c5513-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b8c5513

agones-bot avatar Aug 23 '24 21:08 agones-bot

Build Succeeded :partying_face:

Build Id: e9ea72c3-d9b3-4c23-973b-769918f45be7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://774877d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-774877d

agones-bot avatar Aug 27 '24 00:08 agones-bot

Build Succeeded :partying_face:

Build Id: ba4b961e-a943-4f0b-9a70-f3a6fa7f0c13

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://41ff92e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-41ff92e

agones-bot avatar Aug 27 '24 05:08 agones-bot

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Sep 10 '24 17:09 github-actions[bot]

Build Succeeded :partying_face:

Build Id: 37b79bbd-8810-468d-b3d8-852649992c9d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://396bee7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-396bee7

agones-bot avatar Sep 10 '24 19:09 agones-bot

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Sep 10 '24 20:09 github-actions[bot]

Build Failed :sob:

Build Id: 35ab335e-8ac4-41e0-9a2d-44a4fd21f765

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot avatar Sep 10 '24 20:09 agones-bot

Build Succeeded :partying_face:

Build Id: 38b57e55-8f7b-4366-81d8-57c3b3dc9175

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://61d5c12-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-61d5c12

agones-bot avatar Sep 11 '24 00:09 agones-bot

friendly ping @markmandel

vicentefb avatar Sep 17 '24 18:09 vicentefb

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Sep 17 '24 18:09 github-actions[bot]

Build Succeeded :partying_face:

Build Id: bed61055-401a-45cf-acd3-aea1a4cef01e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://b55fcfc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-b55fcfc

agones-bot avatar Sep 17 '24 19:09 agones-bot

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Sep 30 '24 22:09 github-actions[bot]

Build Succeeded :partying_face:

Build Id: 2dac926b-7c10-467c-adf5-630e406b712e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://1f66af1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-1f66af1

agones-bot avatar Oct 01 '24 00:10 agones-bot

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 08 '24 00:10 github-actions[bot]

Build Succeeded :partying_face:

Build Id: 9410f234-83cc-419a-928c-7b71532281aa

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

  • https://91d68d4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3947/head:pr_3947 && git checkout pr_3947
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.44.0-dev-91d68d4

agones-bot avatar Oct 08 '24 01:10 agones-bot

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Nov 06 '24 18:11 github-actions[bot]