gftools icon indicating copy to clipboard operation
gftools copied to clipboard

fix: Wrong escape sequences

Open aragon999 opened this issue 1 year ago • 1 comments

Maybe fixes #1004

aragon999 avatar Jul 15 '24 08:07 aragon999

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 15 '24 08:07 google-cla[bot]

@m4rc1e Sorry it took so long for me to see your request to try this. I don’t face this issue all the time, and often, it just requires me re-running the build one or two times, and then it works. So, that’s odd, but seems to work.

However, I did test this branch, and it worked the first time, and a second time. The code changes also appear sensible enough to me, FWIW.

arrowtype avatar Jan 14 '25 16:01 arrowtype

I fixed the merge conflict and would be happy if this gets merged, as this also fixes a SyntaxWarning since Python 3.12:

/usr/lib/python3.13/site-packages/gftools/push/items.py:220: SyntaxWarning: invalid escape sequence '\s'
  return re.sub("\s+", " ", text).strip()

As the PR did: https://github.com/googlefonts/gftools/pull/1073

Or should I split this PR up?

aragon999 avatar Feb 01 '25 10:02 aragon999