cu2qu icon indicating copy to clipboard operation
cu2qu copied to clipboard

font.info.unitsPerEm seems to be required

Open typemytype opened this issue 9 years ago • 3 comments

https://github.com/googlei18n/cu2qu/blob/master/Lib/cu2qu/ufo.py#L224

would be nice to have some fallback value when the value is not set

typemytype avatar Sep 20 '16 21:09 typemytype

What should the default unitsPerEm value be? I guess 1000. Maybe the UFO spec should say what the fallback value is when the value is not set.

anthrotype avatar Sep 20 '16 22:09 anthrotype

The default 'DEFAULT_MAX_ERR' makes it confusing...

It should not be calculated from UPM if it is not set

On Wednesday, 21 September 2016, Cosimo Lupo [email protected] wrote:

What should the default unitsPerEm value be? I guess 1000. Maybe the UFO spec should say what the fallback value is when the value is not set.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/googlei18n/cu2qu/issues/49#issuecomment-248447981, or mute the thread https://github.com/notifications/unsubscribe-auth/ABIp1uFBLWYbTqDNQmZJhFmgeAStfhj4ks5qsFdjgaJpZM4KCI8q .

gr Frederik www.typemytype.com

typemytype avatar Sep 20 '16 22:09 typemytype

Yeah, that's a bit confusing.

Also, I think we should disallow using a relative approximation error to convert compatibly fonts having different UPEMs, since OpenType Variations must have the same UPEM (if I am not mistaken).

anthrotype avatar Sep 20 '16 23:09 anthrotype