PyDrive icon indicating copy to clipboard operation
PyDrive copied to clipboard

Added a try except block at the end of the Upload() method, trying to…

Open bonny1992 opened this issue 7 years ago • 4 comments

… close the file. If it's not a file, discard the error.

Sorry if not 100% correct but I'm not familiar with pull requests.

bonny1992 avatar Sep 13 '18 21:09 bonny1992

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Sep 13 '18 21:09 googlebot

I signed it!

Il 13 set 2018 23:53, googlebot [email protected] ha scritto:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA Individual signers

Corporate signers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gsuitedevs/PyDrive/pull/144#issuecomment-421165432, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABGdQF7i8uElpgfd1s63s9F7bi0XJoSTks5uatPzgaJpZM4WoRVq.

bonny1992 avatar Sep 13 '18 23:09 bonny1992

CLAs look good, thanks!

googlebot avatar Sep 13 '18 23:09 googlebot

Sorry for the very long delay getting to this PR. It seems like this would cause a problem if you called Upload twice on the same file object. I'm not sure if there are valid uses for that, but the interface doesn't prevent it.

erickoledadevrel avatar Jan 25 '19 15:01 erickoledadevrel