nodejs-logging icon indicating copy to clipboard operation
nodejs-logging copied to clipboard

feat: Open telemetry integration and span Id fix for nodejs logging library

Open cindy-peng opened this issue 1 year ago • 2 comments

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x] Ensure the tests and linter pass
  • [x] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #1490 🦕

This change is to add OpenTelemetry support for nodejs-logging library and fix trace-span correlation issue. More context about this change: https://b.corp.google.com/issues/270985947

Here are the overall and nodejs-logging design doc for this change: go/logging-otel-span-support go/logging-otel-span-support-nodejs

cindy-peng avatar Apr 13 '24 01:04 cindy-peng

Could you put the changes in protos/ in a separate PR? Not sure how related they are to the current changes.

Yea I was trying to remove these as well, but it looks like owlbot committed this automatically to this PR after I removed them: https://github.com/googleapis/nodejs-logging/commit/c25466975361fabd0b9434be6e50f8d624fffbee

cindy-peng avatar Apr 25 '24 03:04 cindy-peng

Could you put the changes in protos/ in a separate PR? Not sure how related they are to the current changes.

Yea I was trying to remove these as well, but it looks like owlbot committed this automatically to this PR after I removed them: c254669

Removed proto changes.

cindy-peng avatar Apr 29 '24 06:04 cindy-peng