Remove flag "skipParentEntryForCloudRun" to skip writing RequestLogEntry for cloud run by default.

Open cindy-peng opened this issue 2 years ago • 0 comments

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe. This is related to the fix for Possible replication of bug from nodejs-logging-bunyan. We fixed the duplicate logging entry for cloud run in 821 with optional flag "skipParentEntryForCloudRun" enabled to avoid breaking changes. This request is to track removing optional flag "skipParentEntryForCloudRun" and make the fix default behavior for cloud run in the next major release.

Describe the solution you'd like Remove optional parameter "skipParentEntryForCloudRun" and related unit tests for existing makeMiddleware function

Describe alternatives you've considered

Additional context Similar issue also exists for repo nodejs-logging-bunyan mentioned in issue 626

Oct 24 '23 20:10 cindy-peng