nodejs-error-reporting icon indicating copy to clipboard operation
nodejs-error-reporting copied to clipboard

transitive dependency on deprecated `punycode` node module

Open leoschweizer opened this issue 1 year ago • 5 comments

This library transitively depends on ent, which uses the now deprecated node module punycode.

npm ls ent
...
└─┬ ...
  └─┬ @google-cloud/[email protected]
    └─┬ @google-cloud/[email protected]
      └── [email protected]

This results in a deprecation warning when running on node >= 21:

(node:23520) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

This has been adressed in @google-cloud/common, see: https://github.com/googleapis/nodejs-common/issues/812 - however @google-cloud/error-reporting does not depend on an up to date version of this library.

So @google-cloud/common must be updated to maintain compatibility with upcoming node releases. Edit: more precisely, @google-cloud/common has been updated on the main branch already here https://github.com/googleapis/nodejs-error-reporting/pull/715/files - but this is still unreleased!

Environment details

  • OS: macos
  • Node.js version: 22.0.0
  • npm version: 10.5.1
  • @google-cloud/error-reporting version: 3.0.5

leoschweizer avatar Apr 30 '24 13:04 leoschweizer

Thank you for reporting! We will release a new version of this package to update @google-cloud/common.

cindy-peng avatar Jul 29 '24 20:07 cindy-peng

Are there any updates to this issue?

bradley-yoo-anrok avatar Jan 21 '25 17:01 bradley-yoo-anrok

There are some testing issues needs to be fixed currently before the next major release that includes fix to update @google-cloud/common: https://github.com/googleapis/nodejs-error-reporting/pull/715/files We are planing working on this so this dependency issue can be fixed.

cindy-peng avatar Jan 21 '25 21:01 cindy-peng

thanks for the update.

bradley-yoo-anrok avatar Jan 21 '25 22:01 bradley-yoo-anrok

Are there any updates to this? Is there an ETA on when we could expect a fix to this?

bradley-yoo-anrok avatar May 12 '25 22:05 bradley-yoo-anrok