google-cloud-python icon indicating copy to clipboard operation
google-cloud-python copied to clipboard

Allow directly passing force to ConfigClient.delete_deployment()

Open jhollowe opened this issue 9 months ago • 2 comments

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [x] Appropriate docs were updated (if necessary)

Fixes #13839 🦕

jhollowe avatar Apr 24 '25 20:04 jhollowe

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 24 '25 20:04 google-cla[bot]

Thanks for your PR! However, this package, like most packages in this repo, is auto-generated, so your changes would be overwritten when there's an API update. If our libraries are not being generated with some needed functionality, could you file an issue detailing what's needed?

Thank you!

vchudnov-g avatar Apr 25 '25 19:04 vchudnov-g

Closing as per https://github.com/googleapis/google-cloud-python/pull/13840#issuecomment-2831253300

We will follow up on https://github.com/googleapis/google-cloud-python/issues/13839

parthea avatar Apr 29 '25 00:04 parthea