google-cloud-python icon indicating copy to clipboard operation
google-cloud-python copied to clipboard

some TextToSpeechAsyncClient methods return Any type

Open AutonomousCat opened this issue 1 year ago • 6 comments

for example

(method) def from_service_account_file(
    filename: str,
    *args: Unknown,
    **kwargs: Unknown
) -> Any

Which leads to issues later, such as lack of syntax hinting when using tts_client.synthesize_speech()

AutonomousCat avatar Mar 02 '24 22:03 AutonomousCat

Could you please provide more context on where you find this issue? More specifically, how this issue is related to the python-pubsub repository.

mukund-ananthu avatar Mar 05 '24 01:03 mukund-ananthu

I'm going to transfer this issue to google-cloud-python which has the source code for google-cloud-texttospeech https://github.com/googleapis/google-cloud-python/tree/main/packages/google-cloud-texttospeech

parthea avatar Mar 05 '24 01:03 parthea

Thanks @parthea . I am removing the api:pubsub label from the issue accordingly.

mukund-ananthu avatar Mar 05 '24 01:03 mukund-ananthu

Oh, I swear I saw an issue on this repo that said it's no longer maintained, and it pointed to that other repo. Maybe I didn't get all the context

AutonomousCat avatar Mar 05 '24 01:03 AutonomousCat

Oh, I swear I saw an issue on this repo that said it's no longer maintained, and it pointed to that other repo. Maybe I didn't get all the context

I apologize for the confusing bug reporting guidance @AutonomousCat. https://github.com/googleapis/google-cloud-python/issues/12363 is related to that issue and it will be fixed soon (https://github.com/googleapis/google-cloud-python/blob/main/.github/ISSUE_TEMPLATE/bug_report.md)

parthea avatar Mar 06 '24 11:03 parthea

Code from https://github.com/googleapis/google-cloud-python/issues/12400#issue-2168079070 that should be updated with type hints.

https://github.com/googleapis/google-cloud-python/blob/358ef49cba7acb091de627293f9f0e5b63f27ece/packages/google-cloud-texttospeech/google/cloud/texttospeech_v1/services/text_to_speech/async_client.py#L105-L118

Related to https://github.com/googleapis/google-cloud-python/issues/10540

parthea avatar Mar 06 '24 11:03 parthea