google-cloud-php
google-cloud-php copied to clipboard
Recapcha: Wrong score conversion
Description
Hi guys,
I just installed this package and noticed a strange behaviour when an object of class Google\Cloud\RecaptchaEnterprise\V1\RiskAnalysis is hydrated from the json response when creating an assessment (especially the score property). I discovered this bug when I tested recaptcha behaviour with a score threshold of 0.9 and it failed because the score was 0.8999999761581421.
Environment details
- OS: MacOS
- PHP version: 8.2
- Package name and version:
googleapis/google-cloud-php-recaptcha-enterprisev1.8.1
Code example
$var = 0.9;
GPBUtil::checkFloat($var);
var_dump($var);
$var = 0.7;
GPBUtil::checkFloat($var);
var_dump($var);
$var = 0.3;
GPBUtil::checkFloat($var);
var_dump($var);
$var = 0.1;
GPBUtil::checkFloat($var);
var_dump($var);
The output is the following : (from https://3v4l.org/CgGYZ)
8.0 - 8.3
float(0.8999999761581421)
float(0.699999988079071)
float(0.30000001192092896)
float(0.10000000149011612)
5.4 - 8.0
float(0.89999997615814)
float(0.69999998807907)
float(0.30000001192093)
float(0.10000000149012)