feat: add support for returnRawResults for table list operation
Table.php adjusted based on the QueryResults.php example
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Sorry to do this @pentium10, but we can blame our CI for nitpicking, not me.
Two failures in the style check:
FILE: ...fs/src/github/google-cloud-php/BigQuery/tests/Unit/TableTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
283 | ERROR | [x] Whitespace found at end of line
310 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Once that's fixed everything else looks good to me.
@jdpedrie I made the changes, but I didn't modified those lines, so it's a root repo issue
@jdpedrie how it's going?
@pentium10 I fixed a couple of syntax errors in your branch, but the tests themselves are failing.
There were 2 errors:
1) Google\Cloud\BigQuery\Tests\Unit\TableTest::testReturnRawResults
Undefined index: numeric_value
2) Google\Cloud\BigQuery\Tests\Unit\TableTest::testReturnRawResultsIsFalse
Undefined index: numeric_value
You can run tests locally via vendor/bin/phpunit --group bigquery.
Hi @pentium10 I know it's been a while that any activity has happened on this PR, but there are 2 small errors that need to be resolved.
As John has mentioned you can run the unit tests locally using ./vendor/bin/phpunit -c phpunit.xml.dist --group bigquery from inside the BigQuery subdirectory.
Since the tests mentions $this->rowData to be returned, checking for numerical_value may be a typo as that index doesn't exist in the $this->rowData.
Closing this for now as there hasn't been any activity after my last comment.