google-cloud-php icon indicating copy to clipboard operation
google-cloud-php copied to clipboard

feat: add support for returnRawResults for table list operation

Open pentium10 opened this issue 5 years ago • 7 comments

Table.php adjusted based on the QueryResults.php example

pentium10 avatar Mar 15 '21 22:03 pentium10

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 15 '21 22:03 google-cla[bot]

@googlebot I signed it!

pentium10 avatar Mar 15 '21 22:03 pentium10

Sorry to do this @pentium10, but we can blame our CI for nitpicking, not me.

Two failures in the style check:

FILE: ...fs/src/github/google-cloud-php/BigQuery/tests/Unit/TableTest.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 283 | ERROR | [x] Whitespace found at end of line
 310 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Once that's fixed everything else looks good to me.

jdpedrie avatar Apr 06 '21 16:04 jdpedrie

@jdpedrie I made the changes, but I didn't modified those lines, so it's a root repo issue

pentium10 avatar Apr 24 '21 19:04 pentium10

@jdpedrie how it's going?

pentium10 avatar May 25 '21 20:05 pentium10

@pentium10 I fixed a couple of syntax errors in your branch, but the tests themselves are failing.

There were 2 errors:

1) Google\Cloud\BigQuery\Tests\Unit\TableTest::testReturnRawResults
Undefined index: numeric_value

2) Google\Cloud\BigQuery\Tests\Unit\TableTest::testReturnRawResultsIsFalse
Undefined index: numeric_value

You can run tests locally via vendor/bin/phpunit --group bigquery.

jdpedrie avatar May 28 '21 14:05 jdpedrie

Hi @pentium10 I know it's been a while that any activity has happened on this PR, but there are 2 small errors that need to be resolved.

As John has mentioned you can run the unit tests locally using ./vendor/bin/phpunit -c phpunit.xml.dist --group bigquery from inside the BigQuery subdirectory.

Since the tests mentions $this->rowData to be returned, checking for numerical_value may be a typo as that index doesn't exist in the $this->rowData.

saranshdhingra avatar Sep 12 '22 12:09 saranshdhingra

Closing this for now as there hasn't been any activity after my last comment.

saranshdhingra avatar Jun 02 '23 10:06 saranshdhingra