Revisit the need of DOCLET_VERSION env variable (in Jan 2023)

[suztomo]

In Jan 2023, let's revisit the need of if statement and the environment variable to specify doclet version in https://github.com/googleapis/google-cloud-java/pull/8753.

[lqiu96]

There is an issue in java-docfx-doclet for publishing the doclet artifact to maven central: https://github.com/googleapis/java-docfx-doclet/issues/105. I think this should be the long term solution so that we don't need to manually update the version in shared-configs.

DOCLET_VERSION is not needed by default (since shared-configs is specifying the version). I kept the env_var in g3 so that we can publish/update docs by manually setting the DOCLET_VERSION env_var in the fusion job. This is so that we can publish/ update docs even if there is an issue in any future version of the doclet. We can manually rollback the doclet version and publish docs without having to wait for shared-configs' doclet version rollback to be released.

[alicejli]

I think this property can be removed from java-shared-config in general as the publish_javadoc11.sh job is now within google3 and doesn't use this property AFAIK. @burkedavison wdyt?

[burkedavison]

Agreed. Not used. Can be removed.

[alicejli]

Closing this issue as the doclet is managed in java-shared-config and the release scripts are in g3 now.