google-cloud-go icon indicating copy to clipboard operation
google-cloud-go copied to clipboard

fix(spanner): Add ARRAY keywords to keywords

Open kai5263499 opened this issue 2 years ago • 3 comments

Fixes #10078

kai5263499 avatar May 01 '24 18:05 kai5263499

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

GoogleSQL supported Array functions - https://cloud.google.com/spanner/docs/reference/standard-sql/array_functions

harshachinta avatar May 06 '24 08:05 harshachinta

GoogleSQL supported Array functions - https://cloud.google.com/spanner/docs/reference/standard-sql/array_functions

This list appears to match what I've added in my PR. Is there something else I should add here?

kai5263499 avatar May 09 '24 19:05 kai5263499

@kai5263499 Please add tests in parse_test.go similar to https://github.com/googleapis/google-cloud-go/pull/9557?

harshachinta avatar May 14 '24 11:05 harshachinta

@kai5263499 Please add tests in parse_test.go similar to #9557?

I added tests. That led me to remove ARRAY_FILTER because it expects a lambda expression and that would need to be a brand new type for the parser to support. I'll create a separate issue to track the work that needs to be done to support it.

kai5263499 avatar May 14 '24 15:05 kai5263499